Re: Re: test failures for 2.2 on Debian buildd's

On Sun, Dec 23, 2018 at 04:06:29PM +0900, David Bremner wrote:
>Eventually I narrowed this down to (what I believe is) a racy test.
>test/authtest-smtp.sh removes it's input file, but since it is run by
>tcpserver, this happens in a different process than tests/smtp-auth. It
>seems that in certain circumstances this can cause a race condition
>where the previous test removes the smtp-response file wanted for the
>current test. The obvious patch is attached.

I don't think this actually resolves anything. The tests/smtp-auth
script runs the SMTP protocol module, which waits for responses from the
authtest-smtp.sh script. As such, it should not exit until the response
is displayed and subsequently removed. You are however right that the rm
is unneeded, so I will apply something similar anyways.

-- 
Bruce Guenter <[email protected]>                https://untroubled.org/