Re: [PATCH v6] staging: greybus: Constify gb_audio_module_type
Dan Carpenter <[email protected]>
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Mar 19, 2024 at 12:36:25AM +0530, Ayush Tiwari wrote: > Constify static struct kobj_type gb_audio_module_type to prevent > modification of data shared across many instances and to address the > checkpatch warning that "gb_audio_module_type" should be const. The > "gb_audio_module_type" struct is only used in one place: > err = kobject_init_and_add(&m->kobj, &gb_audio_module_type, NULL, ... > so checkpatch is correct that it can be made const. > > Signed-off-by: Ayush Tiwari <[email protected]> Thanks! Reviewed-by: Dan Carpenter <[email protected]> regards, dan carpenter