Re: [PATCH 6.1.y-cip 00/23] Add p3t1085 and p3t1755 support

Hi Pavel,
Thanks for your review.

On 7/20/26 22:14, Pavel Machek wrote:
> hi!
> 
>> This series adds p3t1085 and p3t1755 i3c sensors support into linux-6.1.y-cip
>> kernel.
> 
> I see support being added, but not being used. Could you provide some
> background information?


I3C devices support DAA (Dynamic Address Assignment), so once the driver
is enabled at defconfig level, the controller will discover and bind 
them automatically, no static device node is required in the DT.

On RZ/G3E we already have I3C enabled [1], once the driver probes, it
finds the right devices via DAA.

Some results from testing after enabling the following defconfigs:

CONFIG_I3C=m
CONFIG_RENESAS_I3C=m
CONFIG_SENSORS_TMP108=m
CONFIG_SENSORS_LM75=m
CONFIG_THERMAL=y
CONFIG_THERMAL_HWMON=y

root@smarc-rzg3e:~# cat /proc/interrupts | grep i3c
146:         11          0          0          0     GICv3 709 Edge 
i3c-resp
147:          0          0          0          0     GICv3 712 Edge 
i3c-rx
148:          0          0          0          0     GICv3 713 Edge 
i3c-tx
149:          0          0          0          0     GICv3 721 Level 
i3c-start
150:          0          0          0          0     GICv3 722 Level 
i3c-stop
151:          0          0          0          0     GICv3 724 Level 
i3c-tend
152:          0          0          0          0     GICv3 725 Level 
i3c-nack
root@smarc-rzg3e:~# cat /sys/class/hwmon/*/temp1_input
29443
root@smarc-rzg3e:~# uname -a
Linux smarc-rzg3e 6.1.175-cip57-00064-g14df706f84ef #17 SMP PREEMPT Fri 
Jul 17 12:14:21 CEST 2026 aarch64 GNU/Linux


root@smarc-rzg3e:~# cat /proc/interrupts | grep i3c
146:         11          0          0          0     GICv3 709 Edge 
i3c-resp
147:          0          0          0          0     GICv3 712 Edge 
i3c-rx
148:          0          0          0          0     GICv3 713 Edge 
i3c-tx
149:          0          0          0          0     GICv3 721 Level 
i3c-start
150:          0          0          0          0     GICv3 722 Level 
i3c-stop
151:          0          0          0          0     GICv3 724 Level 
i3c-tend
152:          0          0          0          0     GICv3 725 Level 
i3c-nack
root@smarc-rzg3e:~# cat /sys/class/hwmon/*/temp1_input
33456

root@smarc-rzg3e:~# uname -a
Linux smarc-rzg3e 6.12.95-cip27-00043-g6eb147c1a999 #10 SMP PREEMPT Fri 
Jul 17 15:20:19 CEST 2026 aarch64 GNU/Linux

I will create also MR for [2] and [3].

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/tree/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi?h=linux-6.1.y-cip#n135
[2] 
https://gitlab.com/cip-project/cip-kernel/cip-kernel-config/-/blob/master/6.1.y-cip/arm64/renesas_defconfig?ref_type=heads
[3] 
https://gitlab.com/cip-project/cip-kernel/cip-kernel-config/-/blob/master/6.12.y-cip/arm64/renesas_defconfig?ref_type=heads

Kind Regards,
Tommaso

> 
> Anyway, I'll have some minor comments here, but those should be fixed
> in mainline, first, so they should not block the merge.
> 
> This looks okay to me.
> 
> Reviewed-by: Pavel Machek <[email protected]>
> 
> I can apply the series if it passes testing and there are no other
> comments.
> 
> Best regards,
> 									Pavel