Re: [PATCH v5 13/17] crash: Assert device_hotplug_lock in crash_get_memory_ranges_nolock()
| Newsgroups | org.kernel.vger.linux-fsdevel,dev.linux.lists.driver-core,dev.linux.lists.loongarch,org.kernel.vger.linux-kernel,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
> crash_get_memory_ranges_nolock() walks memblock, which memory hotplug > modifies under device_hotplug_lock. A caller that does not hold the lock > can race with memblock_double_array() and iterate a freed regions array. > > Add device_hotplug_lock_assert_held() and call it at the top of the > function so that such callers are caught by lockdep. > > Signed-off-by: Jinjie Ruan <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13