Re: [PATCH v5 16/17] arm64: kexec_file: Simplify load_other_segments()
| Newsgroups | org.kernel.vger.linux-fsdevel,dev.linux.lists.driver-core,dev.linux.lists.loongarch,org.kernel.vger.linux-kernel,org.kvack.linux-mm,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
> Use `kbuf` fields directly in crash_prepare_headers() to eliminate > the local variables "headers" and "headers_sz".. > > Advance the assignment to image->elf_headers before > calling kexec_add_buffer(). If kexec_add_buffer() fails, the explicit > vfree() in the error path can be removed, as the global infrastructure > in arch_kimage_file_post_load_cleanup() will handle the cleanup. > > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Baoquan He <[email protected]> > Cc: Breno Leitao <[email protected]> > Signed-off-by: Jinjie Ruan <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=16